Code Review for 4031-scsa1394-scsi_pkt

Prepared by:Jeff (jeffpc) on 2013-Dec-01 10:18 -0500 EST
Workspace:/home/jeffpc/illumos/scsa1394 (at aeb065739e89)
Compare against: HEAD^ (at dee140df5444)
Summary of changes: 219 lines changed: 10 ins; 178 del; 31 mod; 3950 unchg
Patch of changes: 4031-scsa1394-scsi_pkt.patch
Printable review: 4031-scsa1394-scsi_pkt.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/targets/scsa1394/hba.c

4031 scsa1394 violates DDI scsi_pkt(9S) allocation rules
182 lines changed: 10 ins; 145 del; 27 mod; 2496 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/io/1394/targets/scsa1394/sbp2_driver.c

4031 scsa1394 violates DDI scsi_pkt(9S) allocation rules
2 lines changed: 0 ins; 0 del; 2 mod; 999 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/1394/targets/scsa1394/cmd.h

4031 scsa1394 violates DDI scsi_pkt(9S) allocation rules
32 lines changed: 0 ins; 30 del; 2 mod; 133 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/sys/1394/targets/scsa1394/impl.h

4031 scsa1394 violates DDI scsi_pkt(9S) allocation rules
3 lines changed: 0 ins; 3 del; 0 mod; 322 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.