Print this page
5253 kmem_alloc/kmem_zalloc won't fail with KM_SLEEP
5254 getrbuf won't fail with KM_SLEEP

*** 502,515 **** EL(ha, "Not supported for 24xx\n"); return (EINVAL); } nv = kmem_zalloc(sizeof (*nv), KM_SLEEP); - if (nv == NULL) { - EL(ha, "failed, kmem_zalloc\n"); - return (ENOMEM); - } rval = ql_lock_nvram(ha, &start_addr, LNF_NVRAM_DATA); if (rval != QL_SUCCESS) { EL(ha, "failed, ql_lock_nvram=%xh\n", rval); kmem_free(nv, sizeof (*nv)); --- 502,511 ----
*** 609,622 **** nvram_24xx_t *nv; uint32_t *longptr; uint32_t csum = 0; nv = kmem_zalloc(sizeof (*nv), KM_SLEEP); - if (nv == NULL) { - EL(ha, "failed, kmem_zalloc\n"); - return (ENOMEM); - } nv->nvram_version[0] = LSB(ICB_24XX_VERSION); nv->nvram_version[1] = MSB(ICB_24XX_VERSION); nv->version[0] = 1; --- 605,614 ----
*** 686,699 **** uint16_t *wptr; uint8_t *bptr; uint8_t csum; nv = kmem_zalloc(sizeof (*nv), KM_SLEEP); - if (nv == NULL) { - EL(ha, "failed, kmem_zalloc\n"); - return (ENOMEM); - } /* * Set default initialization control block. */ nv->parameter_block_version = ICB_VERSION; nv->firmware_options[0] = BIT_4 | BIT_3 | BIT_2 | BIT_1; --- 678,687 ----
*** 938,951 **** nvram_t *nptr; int rval; QL_PRINT_9(CE_CONT, "(%d): started\n", ha->instance); ! if ((nv = kmem_zalloc(ha->nvram_cache->size, KM_SLEEP)) == NULL) { ! EL(ha, "failed, kmem_zalloc\n"); ! return (ENOMEM); ! } if (ddi_copyin(bp, nv, ha->nvram_cache->size, mode) != 0) { EL(ha, "Buffer copy failed\n"); kmem_free(nv, ha->nvram_cache->size); return (EFAULT); --- 926,936 ---- nvram_t *nptr; int rval; QL_PRINT_9(CE_CONT, "(%d): started\n", ha->instance); ! nv = kmem_zalloc(ha->nvram_cache->size, KM_SLEEP); if (ddi_copyin(bp, nv, ha->nvram_cache->size, mode) != 0) { EL(ha, "Buffer copy failed\n"); kmem_free(nv, ha->nvram_cache->size); return (EFAULT);
*** 1160,1173 **** return (ENOTSUP); } vpd_size = QL_24XX_VPD_SIZE; ! if ((vpd = kmem_zalloc(vpd_size, KM_SLEEP)) == NULL) { ! EL(ha, "failed, kmem_zalloc\n"); ! return (ENOMEM); ! } if (ddi_copyin(bp, vpd, vpd_size, mode) != 0) { EL(ha, "Buffer copy failed\n"); kmem_free(vpd, vpd_size); return (EFAULT); --- 1145,1155 ---- return (ENOTSUP); } vpd_size = QL_24XX_VPD_SIZE; ! vpd = kmem_zalloc(vpd_size, KM_SLEEP); if (ddi_copyin(bp, vpd, vpd_size, mode) != 0) { EL(ha, "Buffer copy failed\n"); kmem_free(vpd, vpd_size); return (EFAULT);
*** 1302,1316 **** } CACHE_UNLOCK(ha); return (rval); } ! if ((vpd = kmem_zalloc(vpd_size, KM_SLEEP)) == NULL) { ! CACHE_UNLOCK(ha); ! EL(ha, "failed, kmem_zalloc\n"); ! return (ENOMEM); ! } /* Quiesce I/O */ if (ql_stall_driver(ha, 0) != QL_SUCCESS) { CACHE_UNLOCK(ha); EL(ha, "ql_stall_driver failed\n"); --- 1284,1294 ---- } CACHE_UNLOCK(ha); return (rval); } ! vpd = kmem_zalloc(vpd_size, KM_SLEEP); /* Quiesce I/O */ if (ql_stall_driver(ha, 0) != QL_SUCCESS) { CACHE_UNLOCK(ha); EL(ha, "ql_stall_driver failed\n");
*** 1574,1587 **** bsize = ha->xioctl->fdesc.block_size; saddr = faddr & ~(bsize - 1); ofst = faddr & (bsize - 1); ! if ((bp = kmem_zalloc(bsize, KM_SLEEP)) == NULL) { ! EL(ha, "kmem_zalloc=null\n"); ! return (QL_MEMORY_ALLOC_FAILED); ! } while (bc) { xfer = bc > bsize ? bsize : bc; if (ofst + xfer > bsize) { xfer = bsize - ofst; --- 1552,1562 ---- bsize = ha->xioctl->fdesc.block_size; saddr = faddr & ~(bsize - 1); ofst = faddr & (bsize - 1); ! bp = kmem_zalloc(bsize, KM_SLEEP); while (bc) { xfer = bc > bsize ? bsize : bc; if (ofst + xfer > bsize) { xfer = bsize - ofst;
*** 2033,2046 **** int rval; QL_PRINT_9(CE_CONT, "(%d): started\n", ha->instance); prop_name = kmem_zalloc(dop->length, KM_SLEEP); - if (prop_name == NULL) { - EL(ha, "failed, kmem_zalloc\n"); - return (ENOMEM); - } if (ddi_copyin((void *)(uintptr_t)dop->buffer, prop_name, dop->length, mode) != 0) { EL(ha, "failed, prop_name ddi_copyin\n"); kmem_free(prop_name, dop->length); --- 2008,2017 ----
*** 2090,2103 **** return (EINVAL); } if (ha->ql_dump_state & QL_DUMP_VALID) { dmp = kmem_zalloc(ha->risc_dump_size, KM_SLEEP); - if (dmp == NULL) { - EL(ha, "failed, kmem_zalloc\n"); - return (ENOMEM); - } dop->length = (uint32_t)ql_ascii_fw_dump(ha, dmp); if (ddi_copyout((void *)dmp, (void *)(uintptr_t)dop->buffer, dop->length, mode) != 0) { EL(ha, "failed, ddi_copyout\n"); --- 2061,2070 ----
*** 2219,2232 **** uint8_t *dp; int rval; QL_PRINT_9(CE_CONT, "(%d): started\n", ha->instance); ! if ((dp = kmem_zalloc(dop->length, KM_SLEEP)) == NULL) { ! EL(ha, "failed, kmem_zalloc\n"); ! return (ENOMEM); ! } if (ddi_copyin((void *)(uintptr_t)dop->buffer, dp, dop->length, mode) != 0) { EL(ha, "ddi_copyin failed\n"); kmem_free(dp, dop->length); --- 2186,2196 ---- uint8_t *dp; int rval; QL_PRINT_9(CE_CONT, "(%d): started\n", ha->instance); ! dp = kmem_zalloc(dop->length, KM_SLEEP); if (ddi_copyin((void *)(uintptr_t)dop->buffer, dp, dop->length, mode) != 0) { EL(ha, "ddi_copyin failed\n"); kmem_free(dp, dop->length);