| Prepared by: | (jeffpc) on 2015-May-08 18:04 -0400 EDT |
|---|---|
| Workspace: | /home/jeffpc/illumos/xhat (at 0c597e21abc3) |
| Compare against: | HEAD^ (at a4a52828db5d) |
| Summary of changes: | 177 lines changed: 32 ins; 128 del; 17 mod; 9229 unchg |
| Patch of changes: | no-need-for-bad-op-segment-op-functions.patch |
| Printable review: | no-need-for-bad-op-segment-op-functions.pdf |
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kmem.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.27 lines changed: 0 ins; 21 del; 6 mod; 1616 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kp.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.24 lines changed: 0 ins; 24 del; 0 mod; 1434 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_kpm.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.71 lines changed: 32 ins; 28 del; 11 mod; 301 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_map.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.18 lines changed: 0 ins; 18 del; 0 mod; 2336 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/common/vm/seg_spt.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.28 lines changed: 0 ins; 28 del; 0 mod; 3058 unchg
Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/sparc/v9/vm/seg_nf.c
no need for bad-op segment op functions The segment drivers have a number of bad-op functions that simply panic. Keeping the function pointer NULL will accomplish the same thing in most cases. In other cases, keeping the function pointer NULL will result in proper error code being returned.9 lines changed: 0 ins; 9 del; 0 mod; 484 unchg
This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.